feat:(SC-3320) Added tests for layout components and bucket components #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Application)
|
Coverage Report (Frontend)
|
kyle1morel
reviewed
Oct 17, 2023
kyle1morel
reviewed
Oct 17, 2023
kyle1morel
reviewed
Oct 17, 2023
jujaga
approved these changes
Oct 17, 2023
TimCsaky
approved these changes
Oct 17, 2023
kyle1morel
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3320
Added a few frontend component tests.
Test for layout components:
-Footer
-Navbar
-ProgressLoader
-Spinner
Tests for bucket components:
-BucketConfigForm
-BucketList
-BucketPermission
-BucketPermissionAddUser
-BucketSidebar
-BucketTable
Not all tests are fully complete for the above files, will need more work to improve coverage.
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments